Update to Node 16

[mattjohnsonpint]

Hi. Please update this action to use Node 16.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Thanks.

[IGR2014]

👍

[IGR2014]

Should be fixed till November 14th according to this: actions/runner-images#6482

[jdumas]

@seanmiddleditch any plan to get this merged soon?

[mattjohnsonpint]

FWIW, I ended up just removing this action from our workflow and installing Ninja via package managers instead.

- name: Install Ninja
  shell: bash
  run: ${{ runner.os == 'macOS' && 'brew install ninja' || runner.os == 'Windows' && 'choco install ninja' || 'sudo apt-get install ninja-build' }}

Still, would be good to merge and release this, for those that prefer using the action.

[IGR2014]

For everyone who wants manualy install ninja-build, they can try this:

  # Build Windows
  BuildWindows:

    # Name
    name: 'Build Windows'
    # OS
    runs-on: windows-2022

    # Environments
    env:
      NINJA_DIR: "${{ github.workspace }}/ninja"
      NINJA_VERSION: "1.11.1"

    # Job steps
    steps:

      # Restore Ninja
      - name: 'Restore Ninja'
        id: ninja-cache
        uses: actions/cache@v3
        with:
          path: ${{ env.NINJA_EXE }}
          key: ninja-${{ env.NINJA_VERSION }}-${{ runner.os }}
          restore-keys: |
            ninja-${{ env.NINJA_VERSION }}-${{ runner.os }}
        env:
          NINJA_EXE: "${{ env.NINJA_DIR }}.exe"

      # Install Ninja
      - if: ${{ steps.ninja-cache.outputs.cache-hit != 'true' }}
        name: 'Install Ninja'
        shell: pwsh
        run: |
          Invoke-WebRequest -TimeoutSec 60 -MaximumRetryCount 3 -OutFile "${{ env.NINJA_DIR }}.zip" -URI "${{ env.NINJA_DOWNLOAD_LINK }}"
          7z e "${{ env.NINJA_DIR }}.zip" ninja.exe -r
          & "${{ env.NINJA_EXE }}" --version
        env:
          NINJA_DOWNLOAD_LINK: "https://github.com/ninja-build/ninja/releases/download/v${{ env.NINJA_VERSION }}/ninja-win.zip"
          NINJA_EXE: "${{ env.NINJA_DIR }}.exe"

  # Build Linux
  BuildLinux:

    # Name
    name: 'Build Linux'
    # OS
    runs-on: ubuntu-22.04

    # Environments (only for method №1)
    env:
      NINJA_DIR: "${{ github.workspace }}/ninja"
      NINJA_VERSION: "1.11.1"

    # Job steps
    steps:

      # Method №1:

      # Restore Ninja
      - name: 'Restore Ninja'
        id: ninja-cache
        uses: actions/cache@v3
        with:
          path: ${{ env.NINJA_EXE }}
          key: ninja-${{ env.NINJA_VERSION }}-${{ runner.os }}
          restore-keys: |
            ninja-${{ env.NINJA_VERSION }}-${{ runner.os }}
        env:
          NINJA_EXE: "${{ env.NINJA_DIR }}"

      # Install Ninja
      - if: ${{ steps.ninja-cache.outputs.cache-hit != 'true' }}
        name: 'Install Ninja'
        shell: bash
        run: |
          curl --max-time 60 --retry 3 -L -o "${{ env.NINJA_DIR }}.zip" ${{ env.NINJA_DOWNLOAD_LINK }} 2>&1
          7z e "${{ env.NINJA_DIR }}.zip" ninja -r > nul
          ${{ env.NINJA_EXE }} --version
        env:
          NINJA_DOWNLOAD_LINK: "https://github.com/ninja-build/ninja/releases/download/v${{ env.NINJA_VERSION }}/ninja-linux.zip"
          NINJA_EXE: "${{ env.NINJA_DIR }}"

      # Method №2:

      # Install Ninja
      - name: 'Install Ninja'
        run: |
          sudo apt-get update
          sudo apt-get install --yes --no-install-recommends ninja-build

[silverqx]

This PR looks good to me according to the runs.using docs, so I'm approving it.

@seanmiddleditch why don't you approve it? Is there any specific reason for nodejs 12?

[eisaev]

@seanmiddleditch @EwoutH could you approve this PR?

[abdes]

BTW, given the lack of response, I have forked this repo and fixed it in https://github.com/abdes/gha-setup-ninja. Feel free to use it instead while we wait... maybe forever.....

[offa]

You can consider an alternative too: https://github.com/turtlesec-no/get-ninja

[EwoutH]

@seanmiddleditch @EwoutH could you approve this PR?

Looks good, but I don't have any formal role in this project. For that we need @seanmiddleditch.

[seanmiddleditch]

Wow, this is what I get for letting GitHub notifications get away from me to the point I just started ignoring them. I literally had no idea that not only was there a request to update but a whole community discussion to work around my delinquent maintainership!

I'll get this merged in and a new release pushed out.