Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-807] add filter for empty array params #43

Merged
merged 5 commits into from
Aug 30, 2016

Conversation

alxberardi
Copy link
Contributor

@alxberardi alxberardi commented Aug 29, 2016

Why?

HTTParty v0.14.0 introduced this change:

Unfortunately, when submitting an empty array as a parameter, Rack interprets it as an array containing an empty string:

require 'rack'
Rack::Utils.parse_nested_query('array[]=') #=> {"array"=>[""]}

The workaround is to avoid sending empty arrays to Rack based web applications (such as Rails based QuickTravel)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 76.827% when pulling 730d355 on TT-807-add-filter-for-empty-array-params into 43fc965 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 29, 2016

Coverage Status

Coverage increased (+0.3%) to 76.827% when pulling 730d355 on TT-807-add-filter-for-empty-array-params into 43fc965 on master.

@mnoack
Copy link
Contributor

mnoack commented Aug 29, 2016

👍

@coveralls
Copy link

coveralls commented Aug 29, 2016

Coverage Status

Coverage increased (+0.3%) to 76.827% when pulling c9ba7f3 on TT-807-add-filter-for-empty-array-params into 43fc965 on master.

@coveralls
Copy link

coveralls commented Aug 29, 2016

Coverage Status

Coverage increased (+0.3%) to 76.827% when pulling c9ba7f3 on TT-807-add-filter-for-empty-array-params into 43fc965 on master.

@alxberardi alxberardi changed the title [TT 807] add filter for empty array params [TT-807] add filter for empty array params Aug 30, 2016
@alvinypyim
Copy link
Contributor

👍

@alvinypyim alvinypyim merged commit d497950 into master Aug 30, 2016
@alvinypyim alvinypyim deleted the TT-807-add-filter-for-empty-array-params branch August 30, 2016 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants