Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move login E2E test to image E2E test module #2121

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

  1. move login to image module
  2. rename ginkgo image Describe same with focus

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added e2e-test it needs to run e2e test test labels Mar 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -5.78 ⚠️

Comparison is base (9bb277b) 18.87% compared to head (b4befa8) 13.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   18.87%   13.10%   -5.78%     
==========================================
  Files          95      258     +163     
  Lines        8899    22192   +13293     
==========================================
+ Hits         1680     2908    +1228     
- Misses       6991    18898   +11907     
- Partials      228      386     +158     
Flag Coverage Δ
e2e-tests 9.22% <ø> (?)
unit-tests 18.88% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/application/v2app.go 29.31% <44.44%> (-0.03%) ⬇️
cmd/sealer/cmd/utils/application.go 60.00% <100.00%> (ø)

... and 163 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Stevent-fei
Copy link
Collaborator

/test image

Copy link
Collaborator

@Stevent-fei Stevent-fei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stevent-fei Stevent-fei merged commit adb56a9 into sealerio:main Mar 17, 2023
@kakaZhou719 kakaZhou719 changed the title move login to image module move login E2E test to image E2E test module Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test it needs to run e2e test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants