-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make plugin's on support | #1683
Conversation
10c497f
to
59ac9f2
Compare
Maybe plugin needs selector parameter. |
Codecov ReportBase: 18.06% // Head: 18.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 18.06% 18.05% -0.02%
==========================================
Files 66 66
Lines 5354 5357 +3
==========================================
Hits 967 967
- Misses 4265 4268 +3
Partials 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@YTGhost Any update for this pr? |
59ac9f2
to
4ca69c1
Compare
Sorry for not responding in time because of the busy days, I have made changes according to the code review and rebase |
4ca69c1
to
761d9dd
Compare
@VinceCui @bxy4543 @kakaZhou719 Help take a look at this work. |
Author: HIHIA <[email protected]> Signed-off-by: HIHIA <[email protected]>
761d9dd
to
9863afe
Compare
@kakaZhou719 Please take another look. If it meets, please merge this directly. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe what this PR does / why we need it
make plugin's on support |
Does this pull request fix one issue?
Fixes #1501
Describe how you did it
Describe how to verify it
Special notes for reviews