Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make plugin's on support | #1683

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Sep 2, 2022

Describe what this PR does / why we need it

make plugin's on support |

Does this pull request fix one issue?

Fixes #1501

Describe how you did it

Describe how to verify it

Special notes for reviews

@justadogistaken
Copy link
Member

@YTGhost @bxy4543 I understand the backgroud, but do you have more details? Like the plugins on use case. Maybe we could make the code better based on the actual use cases.

@bxy4543
Copy link
Member

bxy4543 commented Sep 2, 2022

Maybe plugin needs selector parameter.

@bxy4543 bxy4543 closed this Sep 2, 2022
@bxy4543 bxy4543 reopened this Sep 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 18.06% // Head: 18.05% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4ca69c1) compared to base (47f8ada).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   18.06%   18.05%   -0.02%     
==========================================
  Files          66       66              
  Lines        5354     5357       +3     
==========================================
  Hits          967      967              
- Misses       4265     4268       +3     
  Partials      122      122              
Impacted Files Coverage Δ
pkg/plugin/utils.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/plugin/utils.go Outdated Show resolved Hide resolved
pkg/plugin/utils.go Outdated Show resolved Hide resolved
pkg/plugin/utils.go Outdated Show resolved Hide resolved
@justadogistaken
Copy link
Member

@YTGhost Any update for this pr?

@YTGhost
Copy link
Member Author

YTGhost commented Sep 8, 2022

@YTGhost Any update for this pr?

Sorry for not responding in time because of the busy days, I have made changes according to the code review and rebase

@justadogistaken
Copy link
Member

@VinceCui @bxy4543 @kakaZhou719 Help take a look at this work.

pkg/plugin/utils.go Outdated Show resolved Hide resolved
@allencloud
Copy link
Member

@kakaZhou719 Please take another look. If it meets, please merge this directly. Thanks

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit e971bc8 into sealerio:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make plugin's "on" support |
6 participants