Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: delete useless files #1587

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

kakaZhou719
Copy link
Member

@kakaZhou719 kakaZhou719 commented Jul 15, 2022

Describe what this PR does / why we need it

For some historical reasons, we left those useless files which are deleted will not affect sealer stable.

  1. some shell scripts file which is already replaced by the E2E test.
  2. some useless file under hack dir.
  3. some cert file that is no need to keep it in sealer. those certificate file will be generated every time at sealer run process on the server;

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #1587 (f1a92b1) into main (08df4e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1587   +/-   ##
=======================================
  Coverage   11.19%   11.19%           
=======================================
  Files          88       88           
  Lines        8067     8067           
=======================================
  Hits          903      903           
  Misses       7052     7052           
  Partials      112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08df4e0...f1a92b1. Read the comment docs.

@allencloud
Copy link
Member

@bxy4543 @VinceCui Please take a look at this. I would like to double check and move on.

Copy link
Member

@bxy4543 bxy4543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@allencloud allencloud merged commit 1e00d2e into sealerio:main Jul 18, 2022
@kakaZhou719 kakaZhou719 deleted the chore-delete-useless-file branch March 8, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants