bugfix: set wrong auth domain at sealer login #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For these bugfix, we all need to add a test case to cover it. Otherwise, when project becomes complex, we have no idea about if this would introduce another bug, or break other normal functionality. |
|
LGTM |
VinceCui
approved these changes
Jun 9, 2022
bxy4543
pushed a commit
to bxy4543/sealer
that referenced
this pull request
Jun 27, 2022
* bugfix:set wrong auth domain at registry login * add unit test for registry hostname convert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #1459
Describe how you did it
only keep url host at config file for authorization reused if user try login with full url string.
Describe how to verify it
Special notes for reviews