Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new k8s registry #44

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

yuvraj9
Copy link
Contributor

@yuvraj9 yuvraj9 commented Mar 1, 2023

This PR migrate from k8s.gcr.io to registry.k8s.io

Fixes #43
Fixes kubernetes/k8s.io#4780

Signed-off-by: yuvraj singh shekhawat <[email protected]>
@kakaZhou719
Copy link
Member

@Stevent-fei ,could you help to confirm whether this modification is compatible?

@yuvraj9
Copy link
Contributor Author

yuvraj9 commented Mar 9, 2023

@Stevent-fei @kakaZhou719 can you merge this?

@Stevent-fei
Copy link
Collaborator

ok

Copy link
Collaborator

@Stevent-fei Stevent-fei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stevent-fei
Copy link
Collaborator

@yuvraj9 This modification will lead to incompatibility. After the modification, there will be some problems. It will not be merged into the main branch first.

let me check the cause of the problem first

@yuvraj9
Copy link
Contributor Author

yuvraj9 commented Mar 16, 2023

@Stevent-fei just a reminder for this. Also let me know if i can help in someway.

@ahmedwaleedmalik
Copy link

@Stevent-fei any update on this?

@Stevent-fei
Copy link
Collaborator

@Stevent-fei any update on this?

@ahmedwaleedmalik @yuvraj9 I am ready to merge this code into the main branch, and the issue has been resolved.

@Stevent-fei Stevent-fei merged commit e02ef96 into sealerio:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants