Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failing ci tests due to deprecated disutils #309

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Sep 12, 2024

This PR fixes the current failing tests caused by deprecation of disutils: https://numpy.org/doc/stable/reference/distutils_status_migration.html#distutils-status-migration... Due to this deprecation, the build backend for f2py is now meson: https://numpy.org/doc/stable/f2py/buildtools/meson.html. For now, we are just pinning versions to ensure that the software is not failing. Future migrations will be needed to support newer versions of numpy.

@lsetiawan lsetiawan changed the title ci: Update nox to be verbose ci: Fix failing ci tests due to deprecated disutils Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (181ed89) to head (0c0d5ac).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   76.35%   76.35%           
=======================================
  Files          29       29           
  Lines        1789     1789           
=======================================
  Hits         1366     1366           
  Misses        423      423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnbdesanto johnbdesanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnbdesanto johnbdesanto merged commit f398590 into main Sep 12, 2024
8 checks passed
@johnbdesanto johnbdesanto deleted the lsetiawan-patch-1 branch September 12, 2024 21:03
@johnbdesanto johnbdesanto restored the lsetiawan-patch-1 branch September 12, 2024 21:09
@johnbdesanto johnbdesanto deleted the lsetiawan-patch-1 branch September 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants