-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Residual Plotting Functionality #174
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 42.22% 38.39% -3.83%
==========================================
Files 15 16 +1
Lines 746 823 +77
==========================================
+ Hits 315 316 +1
- Misses 431 507 +76
☔ View full report in Codecov by Sentry. |
@johnbdesanto Please let me know if the demo plots above looks okay to you. The time axis seems like there might be too much ticks... currently it defaults to |
The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels. I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine. |
That's what I thought. I actually made the underlying function super easy to adjust the ticks, so yes we can reduce it. I set to
Thanks for checking on that. I haven't really thought about the colors. I will change that to make sure it's the most colorblind friendly! Really appreciate your input @johnbdesanto 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of inline comments and looks like some missing tests.
Thanks! I'm skipping tests for now. Trying to get this out for user testing atm |
Overview
This PR initialized qc module and residual plotting functionality such as plotting the ENU components and residuals together with outliers/deletions flagging.
Reference
Issue #149
Issue #148
Demo Plots
Residuals
ENU Components