Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Residual Plotting Functionality #174

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: Add Residual Plotting Functionality #174

merged 6 commits into from
Oct 19, 2023

Conversation

lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Oct 16, 2023

Overview

This PR initialized qc module and residual plotting functionality such as plotting the ENU components and residuals together with outliers/deletions flagging.

Reference

Issue #149
Issue #148

Demo Plots

Residuals

res

ENU Components

enu_comps

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (5b2c526) 42.22% compared to head (a67579f) 38.39%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   42.22%   38.39%   -3.83%     
==========================================
  Files          15       16       +1     
  Lines         746      823      +77     
==========================================
+ Hits          315      316       +1     
- Misses        431      507      +76     
Files Coverage Δ
src/gnatss/cli.py 29.78% <0.00%> (-6.12%) ⬇️
src/gnatss/ops/qc.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan lsetiawan marked this pull request as ready for review October 16, 2023 23:06
@lsetiawan
Copy link
Member Author

@johnbdesanto Please let me know if the demo plots above looks okay to you. The time axis seems like there might be too much ticks... currently it defaults to 25 ticks.. maybe I need to reduce this.

@johnbdesanto
Copy link
Collaborator

The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.

I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.

@lsetiawan
Copy link
Member Author

The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.

That's what I thought. I actually made the underlying function super easy to adjust the ticks, so yes we can reduce it. I set to 15 and this is what I get:

Screenshot 2023-10-16 at 4 27 55 PM

I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.

Thanks for checking on that. I haven't really thought about the colors. I will change that to make sure it's the most colorblind friendly!

Really appreciate your input @johnbdesanto 😄

@lsetiawan
Copy link
Member Author

lsetiawan commented Oct 16, 2023

Updated demo after n_ticks = 15 and now using a more colorblind friendly colors

res

enu_comps

Copy link
Contributor

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of inline comments and looks like some missing tests.

src/gnatss/ops/qc.py Outdated Show resolved Hide resolved
src/gnatss/ops/qc.py Show resolved Hide resolved
@lsetiawan
Copy link
Member Author

Couple of inline comments and looks like some missing tests.

Thanks! I'm skipping tests for now. Trying to get this out for user testing atm

@lsetiawan lsetiawan merged commit 2b265b4 into seafloor-geodesy:main Oct 19, 2023
3 of 5 checks passed
@lsetiawan lsetiawan deleted the add_qc branch October 19, 2023 22:36
@lsetiawan lsetiawan linked an issue Oct 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to compute e,n,u components from residuals
3 participants