Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add input for outlier threshold #171

Merged
merged 3 commits into from
Oct 19, 2023
Merged

feat: Add input for outlier threshold #171

merged 3 commits into from
Oct 19, 2023

Conversation

lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Oct 16, 2023

Overview

This PR adds input for outlier threshold, so that a RuntimeError can be raised when outliers exceed the number of data. Additionally, modified the original residual limit to 10000.0


Ref: #170

@lsetiawan lsetiawan requested a review from carlosgjs October 16, 2023 18:18
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5b2c526) 42.22% compared to head (56e644b) 42.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   42.22%   42.07%   -0.15%     
==========================================
  Files          15       15              
  Lines         746      751       +5     
==========================================
+ Hits          315      316       +1     
- Misses        431      435       +4     
Files Coverage Δ
src/gnatss/cli.py 35.89% <100.00%> (ø)
src/gnatss/constants/__init__.py 100.00% <100.00%> (ø)
src/gnatss/main.py 18.34% <0.00%> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two minor comments

src/gnatss/main.py Outdated Show resolved Hide resolved
src/gnatss/main.py Outdated Show resolved Hide resolved
@lsetiawan lsetiawan self-assigned this Oct 18, 2023
@lsetiawan lsetiawan merged commit ac36f7e into seafloor-geodesy:main Oct 19, 2023
3 of 5 checks passed
@lsetiawan lsetiawan deleted the outlier_threshold branch October 19, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants