test(loaders): Add test for load_travel_times #125

[madhavmk]

• Add unittest coverage for loaders.py load_travel_times()
• Issue -> Add test for load_travel_times #125

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0a7e30) 39.12% compared to head (dc0c5ab) 41.31%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   39.12%   41.31%   +2.18%     
==========================================
  Files          16       16              
  Lines         823      823              
==========================================
+ Hits          322      340      +18     
+ Misses        501      483      -18     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[madhavmk]

Thanks for the PR suggestions @lsetiawan . I have resolved them, and updated the PR.

[lsetiawan]

This is great @madhavmk. I think you've got all the pieces to make this test fully complete.

I do have change request to make to ensure that the code follows the DRY (Don't Repeat Yourself) principle of software development. Let me know if you have any questions. Thanks!

[madhavmk]

This is great @madhavmk. I think you've got all the pieces to make this test fully complete.

I do have change request to make to ensure that the code follows the DRY (Don't Repeat Yourself) principle of software development. Let me know if you have any questions. Thanks!

Thanks for the review @lsetiawan . You were right, the code blocks were repeated twice for no reason. I've made the requested changes, and will keep the DRY principles in mind in the future too!!

Regarding creating a new load_configuration() fixture, I was planning on incorporating that change in Issue #127 (Because this PR is too big already)

[lsetiawan]

Thanks for working on this and improving it! Great work! I think this is ready to be merged now 😄