Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(loaders): Add test for load_sound_speed #166

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

madhavmk
Copy link
Collaborator

@madhavmk madhavmk commented Oct 11, 2023

* Improve unittest coverage for loaders.py `load_sound_speed()`
* Issue seafloor-geodesy#124 seafloor-geodesy#124
@madhavmk madhavmk self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (584972b) 41.95% compared to head (54cb30d) 42.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   41.95%   42.22%   +0.26%     
==========================================
  Files          15       15              
  Lines         746      746              
==========================================
+ Hits          313      315       +2     
+ Misses        433      431       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsetiawan lsetiawan merged commit 5b2c526 into seafloor-geodesy:main Oct 11, 2023
5 checks passed
@lsetiawan lsetiawan linked an issue Oct 11, 2023 that may be closed by this pull request
@madhavmk madhavmk deleted the issue_124 branch May 14, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for load_sound_speed
2 participants