feat(posfilter): Adds config model for Position Filtering #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration model of 'PositionFilter' to 'configs.posfilter'. Allowing for configurations for position filtering routines. The configuration is also optional within the main config.
Added simple testing for position filter configuration 'roll_pitch_heading' path, as well as usage within main configuration via environment variables.
lsetiawan
commented
Aug 16, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 43.39% 43.39%
=======================================
Files 15 15
Lines 613 613
=======================================
Hits 266 266
Misses 347 347 ☔ View full report in Codecov by Sentry. |
The creation of blank csv file and setting environment variable is now placed in 'root/conftest.py' file as fixtures so the code is DRY.
|
This is ready for your 2nd round of review. Thanks @aniketfadia96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds configuration pydantic model for future position filtering routine. At the moment, it adds a way to pass in the Roll Pitch Heading data.
Closes #129