Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update codebase to use Pydantic v2 #133

Merged
merged 3 commits into from
Aug 16, 2023
Merged

refactor: update codebase to use Pydantic v2 #133

merged 3 commits into from
Aug 16, 2023

Conversation

lsetiawan
Copy link
Member

Overview

This PR refactor the pydantic models to use Pydantic version 2 and its best practices. Additionally, the version for autodoc_pydantic is now bumped to 2 as well.

Closes #85

@lsetiawan lsetiawan self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (533b20a) 43.39% compared to head (1ee890b) 43.39%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files          15       15           
  Lines         613      613           
=======================================
  Hits          266      266           
  Misses        347      347           
Files Changed Coverage Δ
src/gnatss/loaders.py 22.80% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aniketfadia96 aniketfadia96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Pydantic before so I don't have major comments. Added a minor comment, but overall LGTM.

@lsetiawan lsetiawan merged commit b285683 into seafloor-geodesy:main Aug 16, 2023
5 checks passed
@lsetiawan lsetiawan deleted the pydantic_v2 branch August 16, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the use of pydantic version 1 to 2
2 participants