SMC Capability #24
SMC Capability #24
Conversation
|
From the style checker: #ifdef CONFIG_ALLOW_SMC_CALLS
/* Function pointer to SMC capability list */
- seL4_CPtr (*vm_get_smc_cap)(seL4_Word smc_call);
+ seL4_CPtr(*vm_get_smc_cap)(seL4_Word smc_call);
#endifI could change this to appease CI, but since it is a function pointer, I am not sure why it is telling me to make that change. I see plenty of other function pointers in this format throughout the codebase. |
For what it's worth I like your version better, but there is little choice but to follow the style checker, because it will otherwise fail forever. It might well be that it's a bug in the style checker where it treats built-in types differently to declared types in this instance or something like that. Grepping through the code base, it does seem that the style checker version is used almost everywhere where seL4_CPtr is returned. I could find only one instance that mentions a function pointer and So I think we should just change it and comply to the style checkers wishes even if it's a bit strange. |
libsel4vmmplatsupport/plat_include/zynqmp/sel4vmmplatsupport/plat/sip.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good from my side, but someone with more experience on the library side should have another look. @kent-mcleod or @Indanz maybe?
libsel4vmmplatsupport/plat_include/zynqmp/sel4vmmplatsupport/plat/sip.h
Outdated
Show resolved
Hide resolved
| if (!vm_smc_handler) { | ||
| ZF_LOGE("Failed to register smc_handler callback: Invalid callback"); | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
An alternative would be to set it back to the default instead. The people can call this with NULL to unregister their callback.
This required a new callback to be added to the vm_arch struct for ARM. The old handle_smc function gets registered as the smc handler by default. The callback allows a user to register a custom smc handler instead. This is especially useful to allow SMC forwarding in the user's custom handler. Signed-off-by: Robbie VanVossen <[email protected]>
|
@kent-mcleod Can you merge this? |
Add a new capability which certain threads can invoke so seL4 can make SMC calls on ARM platforms in EL2 (virtualized mode) on the thread’s behalf.
See https://sel4.atlassian.net/browse/RFC-9