Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't have PR runs cancel each other #69

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Jan 30, 2024

Just cancel all older hardware runs for the current PR.

This fixes #65

@axel-h axel-h requested a review from lsf37 January 30, 2024 01:38
Just cancel all older hardware runs for the current PR.

Signed-off-by: Axel Heider <[email protected]>
@axel-h
Copy link
Member Author

axel-h commented Jan 30, 2024

See a ci run here, where a new push cancels the older run: https://github.com/seL4/camkes-vm-examples/actions/runs/7705093249?pr=64

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is good. For PRs it makes sense to have the concurrency control at the workflow level and to also cancel the build steps. That'll save runners which are getting scarcer (one PR with a full seL4test HW run on the seL4 repo has 72 jobs currently).

For deployment runs, I kept cancel-in-progress on false to get deployments for those jobs that had already started, but for PRs discarding makes more sense.

I initially thought that the scope of the concurrency control is org-wide, but according to https://github.com/orgs/community/discussions/78332 this is not the case, so using the workflow name is fine.

@lsf37 lsf37 merged commit 512263d into seL4:master Jan 30, 2024
13 checks passed
@lsf37 lsf37 added the CI label Jan 30, 2024
@axel-h axel-h deleted the patch-axel-2 branch January 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github CI concurrency seems to cancel runs due to priority quirks
2 participants