Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Company model #351

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Conversation

jmor528
Copy link
Collaborator

@jmor528 jmor528 commented Apr 2, 2022

  • Added image field to model
  • Altered persons list to not be mandatory
  • Updated tests and endpoints accordingly

@jmor528 jmor528 linked an issue Apr 2, 2022 that may be closed by this pull request
5 tasks
seanhogunkim
seanhogunkim previously approved these changes Apr 2, 2022
Copy link
Collaborator

@seanhogunkim seanhogunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything ran as expected on my end, LGTM. Nice, clean and readable code + good comprehensive test suite nice work

Copy link
Collaborator

@seanhogunkim seanhogunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense for Company to store the reference, good edge case pickup

@jmor528 jmor528 merged commit 395401c into se701team3:main-a2 Apr 2, 2022
abis555 pushed a commit to abis555/Forgettable that referenced this pull request Apr 5, 2022
* Updating Company model

* Person can be created to already belong to company
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Company Model
2 participants