Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#222] Add in Labels for Categorising People #348

Merged
merged 7 commits into from
Apr 2, 2022

Conversation

JL-2644
Copy link
Collaborator

@JL-2644 JL-2644 commented Apr 2, 2022

Labels property added to the person model
getPersonByLabel endpoint implemented for future use
Tests for both frontend and backend written and passing

Add label when editing settings as shown:

image

Copy link
Collaborator

@BraveNewWord BraveNewWord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JL-2644 JL-2644 merged commit 032f914 into se701team3:main-a2 Apr 2, 2022
abis555 pushed a commit to abis555/Forgettable that referenced this pull request Apr 5, 2022
* Added labels into person model, created getPersonByLabel endpoint with tests

* Added labels input to person form

* Added label chips to person card

* Added labels to person drawer

* Fixed labels not rendering on person page

* Added conditional rendering for labels

* Updated PersonDrawer snapshot

Co-authored-by: Henry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants