Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#251] add dropdown box #346

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Conversation

Billsong19
Copy link
Collaborator

added dropdown box for gender, replacing the text field.

image

added new InputSelector field to facilitate this

@Billsong19 Billsong19 linked an issue Apr 1, 2022 that may be closed by this pull request
2 tasks
@hmit106
Copy link
Contributor

hmit106 commented Apr 1, 2022

I'm testing out the changes and it seems after making a person with "Unlisted" gender, the "People" page doesn't work (database error in screenshot). I'm not 100% sure the people tab was working beforehand, but since the new unlisted person is now in my database for all forks I can't go back and check - I'll try and figure out how to erase my database to determine if this is introduced by these changes.

Can anyone reproduce this?

image

@hmit106 hmit106 self-requested a review April 1, 2022 10:51
Copy link
Contributor

@hmit106 hmit106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted everything in my database and now I'm unable to reproduce the error I found, likely caused by having existing users in my people tab. If you're also unable to reproduce my error too then I'm happy to approve, LGTM.

Copy link
Collaborator

@harristomy harristomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to see if Henry's issue could be reproduced, but looks good on my end

Copy link
Collaborator

@seanhogunkim seanhogunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't reproduce Henry's error on my end either, everything works for me LGTM. Good clean code 👍

Copy link
Collaborator

@bikkku bikkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could not reproduce, so LGTM.

Copy link
Collaborator

@henrym25 henrym25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues when I ran it as well. LGTM

@Billsong19 Billsong19 merged commit 4e4242f into se701team3:main-a2 Apr 2, 2022
@Billsong19 Billsong19 deleted the gender-dropdown branch April 2, 2022 10:40
abis555 pushed a commit to abis555/Forgettable that referenced this pull request Apr 5, 2022
* add dropdown box for gender selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quality of life features to create/edit person page
7 participants