-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#251] add dropdown box #346
Conversation
forgettable-frontend/src/components/InputSelector/InputSelector.js
Outdated
Show resolved
Hide resolved
I'm testing out the changes and it seems after making a person with "Unlisted" gender, the "People" page doesn't work (database error in screenshot). I'm not 100% sure the people tab was working beforehand, but since the new unlisted person is now in my database for all forks I can't go back and check - I'll try and figure out how to erase my database to determine if this is introduced by these changes. Can anyone reproduce this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted everything in my database and now I'm unable to reproduce the error I found, likely caused by having existing users in my people tab. If you're also unable to reproduce my error too then I'm happy to approve, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested to see if Henry's issue could be reproduced, but looks good on my end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't reproduce Henry's error on my end either, everything works for me LGTM. Good clean code 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also could not reproduce, so LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues when I ran it as well. LGTM
* add dropdown box for gender selection
added dropdown box for gender, replacing the text field.
added new InputSelector field to facilitate this