Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change first_name + last_name to display_name for User #220

Open
1 task
noahjade opened this issue Mar 17, 2022 · 0 comments
Open
1 task

Change first_name + last_name to display_name for User #220

noahjade opened this issue Mar 17, 2022 · 0 comments

Comments

@noahjade
Copy link
Contributor

Description

Currently, the User has two fields: first_name and last_name. However, because we are using google authentication through firebase we only have access to the user's display name. This means we cannot reliably determine what a users first and last name is, as splitting by spaces could result in errors for people with spaces in their first name etc. As such currently both first_name and last_name are being populated with the display name.

User's name is currently only used on the dashboard welcoming message, so this isn't high priority. But if future features want to rely on this more this should be cleaned up.

Acceptance Criteria

  • User should have a single name field instead of two

Implementation details

Both the user model and the end point will have to be updated. Any reference to first_name and last_name in the front end will also have to be updated, but there aren't many atm so it should be okay.

Testing notes

  • Existing tests will have to be updated to reflect this change.
@abis555 abis555 self-assigned this Mar 25, 2022
@abis555 abis555 added the team-2 label Mar 25, 2022
abis555 added a commit to abis555/Forgettable that referenced this issue Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants