-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#214] Fix alignment by changing index font #215
Conversation
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@baskargopinath submitted v1 for review.
Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/1/head:BRANCHNAME where |
v2@baskargopinath submitted v2 for review.
(📚 Archive) (📈 Interdiff between v1 and v2) (📈 Range-Diff between v1 and v2) Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/2/head:BRANCHNAME where |
@baskargopinath If the second commit is simply fixing an error introduced by the first commit, the proper fix is to revise the first commit to not introduce the error at all. That way, we avoid polluting the history with unnecessary commits. |
Understood prof will fix it asap @damithc |
For a non-monospace font such as Segoe UI, "1." takes up less horizontal space than "2.". This results in the first name having different vertical alignment compared to all the names below the first one in the PersonListCard. Lets change the font of the index in the PersonListCard to a monospaced font such as Arial Mono, which seems to eliminate the misalignment issue so that the names in the PersonListCard are aligned.
v3@baskargopinath submitted v3 for review.
(📚 Archive) (📈 Interdiff between v2 and v3) (📈 Range-Diff between v2 and v3) Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/3/head:BRANCHNAME where |
@baskargopinath two other comments:
|
@damithc okay ived fixed it prof. I had to delete this repo so i can fork AB3-J17 for 2103R. I have sent the PR from my nus github account instead with the requested changes |
Fixes #214
Explanation below image
cell_big_index
style to use Arial Mono.HBox
andLabel
elements for consistent alignment.