Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail alert does not honour context. #62

Closed
vrongmeal opened this issue Oct 26, 2020 · 0 comments · Fixed by #63
Closed

Mail alert does not honour context. #62

vrongmeal opened this issue Oct 26, 2020 · 0 comments · Fixed by #63
Assignees
@vrongmeal
Labels
bug Something isn't working

Comments

@vrongmeal
Copy link
Contributor

If the context cancels, the mail alerter doesn't exit.
@vrongmeal vrongmeal added the bug Something isn't working label Oct 26, 2020
@vrongmeal vrongmeal added this to the Agent milestone Oct 26, 2020
@vrongmeal vrongmeal self-assigned this Oct 26, 2020
vrongmeal added a commit that referenced this issue Oct 26, 2020
@vrongmeal
Make alerters honour context.
7829606 
- All alerters now return from loop when context is cancelled
- Each individual alert context is now given an explicit timeout
  in the case when there's no deadline set for parent context
- Mail alerter now honours context

Fixes #62

Signed-off-by: Vaibhav <[email protected]>
@vrongmeal vrongmeal mentioned this issue Oct 26, 2020
Merged
murex971 pushed a commit that referenced this issue Oct 27, 2020
@vrongmeal @murex971
Make alerters honour context.
3589c84 
- All alerters now return from loop when context is cancelled
- Each individual alert context is now given an explicit timeout
  in the case when there's no deadline set for parent context
- Mail alerter now honours context

Fixes #62

Signed-off-by: Vaibhav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrongmeal vrongmeal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make alerters honour context. sdslabs/pinger
1 participant
@vrongmeal