Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly handle multiple consecutive ? characters when doing keys pattern match #186

Merged
merged 1 commit into from
May 14, 2020
Merged

properly handle multiple consecutive ? characters when doing keys pattern match #186

merged 1 commit into from
May 14, 2020

Conversation

dpsk
Copy link
Contributor

@dpsk dpsk commented May 13, 2020 •
edited
Loading

Hello, thanks for this library.

Found out that currently redis_pattern_to_ruby_regex doesn't work as intended

As an example it will transform this pattern "^key-????$" into ^key-.?.?$ instead of ^key-....$

i believe that's also what is going on in this issue #178

sds
sds approved these changes May 14, 2020
View reviewed changes
Copy link
Owner

@sds sds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, and for adding tests!

@sds sds added the bug label May 14, 2020
@sds sds merged commit d7d9352 into sds:master May 14, 2020
@sds sds mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sds sds sds approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpsk @sds