Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3008 #557

Merged
merged 9 commits into from
Sep 5, 2024
Merged

3008 #557

merged 9 commits into from
Sep 5, 2024

Conversation

lingawakad
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added images Plane images planes Plane info labels Sep 4, 2024
@dziban303
Copy link
Collaborator

@Phaeton I don't know what's going on with the repo, if there's a problem or not.

@Phaeton
Copy link
Collaborator

Phaeton commented Sep 4, 2024

@dziban303 You seeing an error here, or referring to the failed action run I kicked of last week?

@dziban303
Copy link
Collaborator

the failed action.

@Phaeton Phaeton removed their assignment Sep 5, 2024
@Phaeton
Copy link
Collaborator

Phaeton commented Sep 5, 2024

@lingawakad tag me or dzi with a review request when you are done making changes.

@lingawakad
Copy link
Contributor Author

@Phaeton any time, i'm at a good stopping point for now

A67C72,N517LH,Labcorp,Pilatus PC-24,PC24,Civ,Genomes,Medical,Bizjet,As Seen on TV,https://w.wiki/Ahr2
33FD0A,MM62329,Italian Air Force,Gulfstream 5,GLF5,Mil,VIP,Must Be Nice,Virtute Siderum Tenus,Other Air Forces,https://w.wiki/B6Wo
AE74D4,22-03441,United States Army,Boeing AH-64E Apache Guardian,H64,Mil,Air Cavalry,Chopper,Attack Helos,Toy Soldiers,https://w.wiki/8k4B
A0AB51,N142NG,Five Star Marketing,Diamond DA-42 Guardian,DA42,Civ,Surveillance,Covert,Spyplane,Oxcart,https://tinyurl.com/3yvyvhw4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this tagged as a Oxcart/spy plane?

Copy link
Contributor Author

@lingawakad lingawakad Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what the other DA-42s were tagged as, but i guess it could be tagged distinctive or taken out if it isn't actually distinctive

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a standard DA-42 NG, used by a small marketing firm. If its something you want to track, go ahead and put it in, but I'd tag it as As Seen on TV or something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, i'll take it out

plane-alert-db.csv Show resolved Hide resolved
plane-alert-db.csv Show resolved Hide resolved
plane-alert-db.csv Show resolved Hide resolved
plane-alert-db.csv Show resolved Hide resolved
plane-alert-db.csv Show resolved Hide resolved
@Phaeton Phaeton merged commit 67bf1d3 into sdr-enthusiasts:main Sep 5, 2024
4 checks passed
@lingawakad lingawakad deleted the 3008 branch September 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Plane images planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants