Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotka's additions #297

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Kotka's additions #297

merged 2 commits into from
Aug 28, 2023

Conversation

dziban303
Copy link
Collaborator

Describe your changes

kotka's additions in #296

The plane-alert-db additions were duplicated three times. Cut out the extras. Verified via FAA and, occasionally, RB/FA. Smell test passed but I can't guarantee 100% accuracy.

Fixes: AD84BA/N970MB was entered incorrectly, it's a Kaman K-MAX.
King Air codes were BE9L not C90.
Tweaked some plain English model types to match FAA: although the difference between an EC-635 and an EC-135 are apparently small, best to go with what's on the registration, I think. Also went with Squirrels rather than AStar, same thing I guess.

Pics: The pics were messed up. Many or most of the image URLs were duplicated for different aircraft, like the same pic was used for A1801F (correct) as for AC6E92 (incorrect, totally different kind of helicopter). I did not exhaustively review them and I'm not going to try to fix them, so I've just removed them entirely.

Original PR notes:

PLANE INFO:
Sources where I pulled tail numbers from before looking them up in flight trackers. https://www.helis.com/database/org/Texas-Helicopters/,
wildfire helicopters/planes found while watching the area where there have been wildfires.
planes/helicopters caught in my plane fence page.
I searched flightaware, adbs exchange, google, faa for information based on tail numbers.
Photos found from searching google, flightaware, jetpihotos

Checklist before requesting a review

  • I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added images Plane images planes Plane info labels Aug 27, 2023
@Phaeton Phaeton merged commit 4287ffc into sdr-enthusiasts:main Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Plane images planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants