-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hawkeye additions #161
hawkeye additions #161
Conversation
Please only suggest/make any changes to the following files:
All other files are generated from this file using the .github/workflows/create_db_derivatives.yaml GitHub action, and if you do not make your changes there, they will be overwritten and lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes all look good to me. @dziban303 for 168275, possibly the following photo could work https://www.airfighters.com/photo_9999_291207.jpg
@rickstaa should an edit that adds new planes to plane-alert-db.csv
also add the framework to add photos to plane_images.txt
? I see the derivatives action hitting a few other files, but not that one.
Yeah I will add that image to the PR in a bit. It's got a different paint
job now but *shrug*
…On Thu, Mar 16, 2023, 12:46 Phaeton ***@***.***> wrote:
***@***.**** approved this pull request.
these changes all look good to me. @dziban303
<https://github.com/dziban303> for 168275, possibly the following photo
could work https://www.airfighters.com/photo_9999_291207.jpg
@rickstaa <https://github.com/rickstaa> should an edit that adds new
planes to plane-alert-db.csv also add the framework to add photos to
plane_images.txt? I see the derivatives action hitting a few other files,
but not that one.
—
Reply to this email directly, view it on GitHub
<#161 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4QO5N7JOHWEKPXHBWA3QLW4NGWNANCNFSM6AAAAAAV4TL2GA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, I saw that coming, lol. No idea what it's complaining about now. Should be good to go. |
…e not antisubmarine aircraft, heh)
Added image for E-2D AE20F9/168275
Describe your changes
Sources: these a/c traveled as a group from Point Mugu to Key West today using LBERTY5x callsigns, a callsign used previously for members of VAW-115, The Liberty Bells, a Navy squadron which flies E-2 Hawkeyes. Imagery from the past year was found on twitter of two of these aircraft, confirming their hexes and tailcodes. Photos of the other two could not be located, but others have confirmed they are indeed Hawkeyes.
I didn't see any indication that the photos I found were free to use so I am not including them in the photos database.
Checklist before requesting a review