-
Notifications
You must be signed in to change notification settings - Fork 22
Convert ListVersions() to return []PairedVersion #210
Conversation
solve_basic_test.go
Outdated
@@ -1456,20 +1462,32 @@ func (sm *depspecSourceManager) ListPackages(id ProjectIdentifier, v Version) (p | |||
return pkgtree.PackageTree{}, fmt.Errorf("Project %s at version %s could not be found", pid.n, v) | |||
} | |||
|
|||
func (sm *depspecSourceManager) ListVersions(id ProjectIdentifier) (pi []Version, err error) { | |||
func (sm *depspecSourceManager) ListVersions(id ProjectIdentifier) ([]PairedVersion, error) { | |||
pvl := make([]PairedVersion, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably use "var pvl []PairedVersion" instead
An enterprising soul could probably figure this one out and update this issue with a suggestion about where the problem is 😄 The goal within the test harness - in |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 78.02% 74.83% -3.19%
==========================================
Files 28 4 -24
Lines 4018 465 -3553
==========================================
- Hits 3135 348 -2787
+ Misses 659 95 -564
+ Partials 224 22 -202
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 79.01% 79.41% +0.39%
==========================================
Files 30 31 +1
Lines 4175 4143 -32
==========================================
- Hits 3299 3290 -9
+ Misses 649 624 -25
- Partials 227 229 +2
Continue to review full report at Codecov.
|
This is almost complete, except one test is still failing in a way that indicates the test harness still isn't quite dealing with the underlying FAKEREVs correctly.
Convert ListVersions() to return []PairedVersion
This is almost complete, except one test is still failing in a way that
indicates the test harness still isn't quite dealing with the underlying
FAKEREV
s correctly.Fixes #202.