Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Canceling monitored cmd causes panic #218

Closed
sdboyer opened this issue Apr 17, 2017 · 0 comments
Closed

Canceling monitored cmd causes panic #218

sdboyer opened this issue Apr 17, 2017 · 0 comments
Labels
bug

Comments

@sdboyer
Copy link
Owner

sdboyer commented Apr 17, 2017

golang/dep#396 demonstrated that signaling dep to stop would cause a panic on monitored cmds.

This was really just some crufty code that I didn't clean up in #196, and also clearly didn't have a test path for.
@sdboyer sdboyer added the bug label Apr 17, 2017
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
@sdboyer
Remove crufty monitoredCmd.ctx & add a test case
eaa693e 
Fixes sdboyer/gps#218.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdboyer