Fix #22: Remove numpy dependency on info setup.py commands. #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks what setup command is passed. If it is one of the info commands, (e.g. "egg_info") then
numpy
is not required and so is not imported for dependency determination .Allows dependency determination without
numpy
, thus resolving #22, allowing pip to installPyAstronomy
andnumpy
at the same time.Inspired by the
setup.py
file forscipy
.I have only tested it locally using a fresh conda enviroment (without
numpy
installed).Running
pip install -e .
fails.but with this PR
pip install -e . numpy --no-cache
works.When this is pushed to pypi this should allow
PyAstronomy
to be placed alongsidenumpy
in arequirements.txt
and be installed on fresh environments.