Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update #1314

Merged
merged 19 commits into from
Dec 31, 2024
Merged

UI update #1314

merged 19 commits into from
Dec 31, 2024

Conversation

kwiato
Copy link
Contributor

@kwiato kwiato commented Dec 19, 2024

No description provided.

@dgarcia360
Copy link
Collaborator

dgarcia360 commented Dec 20, 2024

Feedback:

@dgarcia360 dgarcia360 self-requested a review December 24, 2024 10:37
@dgarcia360
Copy link
Collaborator

LGTM!

I added some edits:

  • Changed anchor icon & updated icons lib
  • Anchor icon is copied on hover + click
  • Add configurable brand variables in conf.py

@dgarcia360
Copy link
Collaborator

@annastuchlik ready for review

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@dgarcia360 dgarcia360 merged commit d2e90b6 into scylladb:master Dec 31, 2024
5 checks passed
@tzach
Copy link
Collaborator

tzach commented Jan 1, 2025

@kwiato @dgarcia360 in the future, please include before and after UI capture in the PR comments.
It would make review easier. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants