-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement experimental websocket client #2552
Open
p12tic
wants to merge
13
commits into
scylladb:master
Choose a base branch
from
p12tic:websocket-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,138
−551
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c440009
http: Expose connection_factory implementations
p12tic 453a5ae
websocket: Extract code not specific to server to separate file
p12tic 008c4bc
websocket: Rename connection to server_connection
p12tic 65e1e75
websocket: Extract parts of server_connection usable for client
p12tic cd8153b
websocket: Rename wlogger to websocket_logger
p12tic 44a20aa
websocket: extract encode_base64() function
p12tic 2355592
websocket: Add a way to declare that payload is masked
p12tic 793c5fb
websocket: Add support for parsing messages coming from server
p12tic 6f1d5ae
http: Make request writing functions public
p12tic 05e928f
websocket: Add experimental client implementation
p12tic 4dcc838
demos: Add a way to set port from cmd line in websocket demo
p12tic 12415c2
demos: Rename websocket demo to websocket_server demo
p12tic ec8a235
demos: Add websocket client demo
p12tic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
* This file is open source software, licensed to you under the terms | ||
* of the Apache License, Version 2.0 (the "License"). See the NOTICE file | ||
* distributed with this work for additional information regarding copyright | ||
* ownership. You may not use this file except in compliance with the License. | ||
* | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include <seastar/core/seastar.hh> | ||
#include <seastar/net/api.hh> | ||
#include <seastar/net/tls.hh> | ||
|
||
namespace seastar::http::experimental { | ||
|
||
/** | ||
* \brief Factory that provides transport for \ref client | ||
* | ||
* This customization point allows callers provide its own transport for client. The | ||
* client code calls factory when it needs more connections to the server. | ||
*/ | ||
|
||
class connection_factory { | ||
public: | ||
/** | ||
* \brief Make a \ref connected_socket | ||
* | ||
* The implementations of this method should return ready-to-use socket that will | ||
* be used by \ref client as transport for its http connections | ||
*/ | ||
virtual future<connected_socket> make(abort_source*) = 0; | ||
virtual ~connection_factory() {} | ||
}; | ||
|
||
class basic_connection_factory : public connection_factory { | ||
socket_address _addr; | ||
public: | ||
explicit basic_connection_factory(socket_address addr) | ||
: _addr(std::move(addr)) | ||
{ | ||
} | ||
virtual future<connected_socket> make(abort_source* as) override { | ||
return seastar::connect(_addr, {}, transport::TCP); | ||
} | ||
}; | ||
|
||
class tls_connection_factory : public connection_factory { | ||
socket_address _addr; | ||
shared_ptr<tls::certificate_credentials> _creds; | ||
sstring _host; | ||
public: | ||
tls_connection_factory(socket_address addr, shared_ptr<tls::certificate_credentials> creds, sstring host) | ||
: _addr(std::move(addr)) | ||
, _creds(std::move(creds)) | ||
, _host(std::move(host)) | ||
{ | ||
} | ||
virtual future<connected_socket> make(abort_source* as) override { | ||
return tls::connect(_creds, _addr, tls::tls_options{.server_name = _host}); | ||
} | ||
}; | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch comment is missing