Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/program-options: selection_value: make get_candidate_names() public #2550

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/seastar/util/program-options.hh
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ private:
size_t _selected_candidate = no_selected_candidate;
bool _defaulted = true;

private:
public:
denesb marked this conversation as resolved.
Show resolved Hide resolved
std::vector<std::string> get_candidate_names() const {
std::vector<std::string> candidate_names;
candidate_names.reserve(_candidates.size());
Expand All @@ -543,6 +543,7 @@ private:
}
return candidate_names;
}
private:
virtual void do_describe(options_descriptor& descriptor) const override {
descriptor.visit_selection_value(get_candidate_names(), _selected_candidate == no_selected_candidate ? nullptr : &_selected_candidate);
for (auto& c : _candidates) {
Expand Down