net/tls: Wait for data_{source,sink}::close() #2547
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
force-pushed
the
wait-tls-data-sink-source-close
branch
2 times, most recently
from
4164e6e
to
4e836f0
Compare
|
Rebased and removed accidentally added whitespace changes |
Fixes scylladb#799 data_{source,sink}::close() return a future. If it is not ready on close() return, then the current tls session close() may result in use after free. Converting close_after_shutdown() to a coroutine and sequentially co_awaiting on close() addresses this issue. The waiting is done sequentially, as this is shutdown path anyway.
p12tic
force-pushed
the
wait-tls-data-sink-source-close
branch
from
4e836f0
to
a0f50e7
Compare
|
Can you add a test that fails before the patch and succeeds after it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
data_{source,sink}::close() return a future. If it is not ready on close() return, then the current tls session close() may result in use after free.
Converting close_after_shutdown() to a coroutine and sequentially co_awaiting on close() addresses this issue. The waiting is done sequentially, as this is shutdown path anyway.