Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: replace CircleCI badge with GitHub badge #2245

Closed
wants to merge 1 commit into from
Closed

README.md: replace CircleCI badge with GitHub badge #2245

wants to merge 1 commit into from

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented May 16, 2024 •
edited
Loading

now that we've dropped the CircleCI integration, let's update
the badge accordingly.

@tchaikov
Copy link
Contributor Author

tchaikov commented May 16, 2024 •
edited
Loading

see https://github.com/scylladb/seastar/blob/960f1b4dcc72779364f38a0f5bf53f3029895151/README.md for the rendered page.

@tchaikov
Copy link
Contributor Author

we also need to remove CircleCI pipeline from the CircleCI. see https://app.circleci.com/projects/project-dashboard/github/scylladb/.

@tchaikov
README.md: replace CircleCI badge with GitHub badge
104f6c8 
now that we've dropped the CircleCI integration, let's update
the badge accordingly.

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov tchaikov added the documentation Documentation - the tutorial, doxygen comments, etc. label May 16, 2024
nyh
nyh approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@nyh nyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we have any of these "badges", but I agree that if we have one let's at least have the right one...

@tchaikov
Copy link
Contributor Author

because they are cute, i think =)

@nyh
Copy link
Contributor

nyh commented May 16, 2024

we also need to remove CircleCI pipeline from the CircleCI. see https://app.circleci.com/projects/project-dashboard/github/scylladb/.

Is the silly CircleCI Pipeline error we see now - "No configuration was found in your project." - because of that?
@avikivity I don't have a circleci account (or don't remember my password for it...) and I guess you do, so can you please remove it?

P.S. @tchaikov we still have that clang download problem, happened again in this PR :-(

@nyh nyh closed this in a7fb8ff May 16, 2024
@tchaikov
Copy link
Contributor Author

we also need to remove CircleCI pipeline from the CircleCI. see https://app.circleci.com/projects/project-dashboard/github/scylladb/.

Is the silly CircleCI Pipeline error we see now - "No configuration was found in your project." - because of that? @avikivity I don't have a circleci account (or don't remember my password for it...) and I guess you do, so can you please remove it?

yes. probably it's authenticated using github?

P.S. @tchaikov we still have that clang download problem, happened again in this PR :-(

yeah, i knew..

@tchaikov tchaikov deleted the readme-badge branch May 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyh nyh nyh approved these changes

Assignees
No one assigned
Labels
documentation Documentation - the tutorial, doxygen comments, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchaikov @nyh