clang-tidy sends false positive warnings

[tchaikov]

for instance:

return open_file_dma(path.native(), oflags, std::move(options)).then([this, path = std::move(path)] (file f) mutable {
   99 |     return open_file_dma(path.native(), oflags, std::move(options)).then([this, path = std::move(path)] (file f) mutable {
      |                          ^
/home/runner/work/scylladb/scylladb/seastar/src/util/tmp_file.cc:99:88: note: move occurred here
   99 |     return open_file_dma(path.native(), oflags, std::move(options)).then([this, path = std::move(path)] (file f) mutable {
      |                                                                                        ^
/home/runner/work/scylladb/scylladb/seastar/src/util/tmp_file.cc:99:26: note: the use and move are unsequenced, i.e. there is no guarantee about the order in which they are evaluated
   99 |     return open_file_dma(path.native(), oflags, std::move(options)).then([this, path = std::move(path)] (file f) mutable {
      |                          ^
Warning: /home/runner/work/scylladb/scylladb/seastar/src/util/tmp_file.cc:146:28: warning: 'path' used after it was moved [bugprone-use-after-move]

this is a known issue of clang-tidy.

see llvm/llvm-project#57758 and llvm/llvm-project#59612. and there is a fix for it, see https://reviews.llvm.org/D145581 . but this patch is now stalled, and has not landed on llvm yet.

[tchaikov]

i am creating this issue just for those who are interested in the false alarms.

[tchaikov]

/cc @raphaelsc

[tchaikov]

created llvm/llvm-project#93623 based on https://reviews.llvm.org/D145581 to address the false alarms.

[raphaelsc]

created llvm/llvm-project#93623 based on https://reviews.llvm.org/D145581 to address the false alarm

great initiative @tchaikov. thanks for submitting it.

[tchaikov]

merged. lemme see if it is allowed to be backported after it passes the tests

[tchaikov]

reopening this issue. because we should be able to use clang-19 which includes the fix . but better off using a distro which has clang-19 prepackaged.

• llvm-19.1.0 included by f41 (https://src.fedoraproject.org/rpms/llvm/c/53aa1f875045639b3cb7bb604eed04da1667d7c7?branch=f41)
• package published to bodhi (check https://bodhi.fedoraproject.org/updates/?packages=llvm)
• package submitted for stable
• update the workflow to use f41 and clang-19