scylla_cql: autoderive Default for Consistency #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
force-pushed
the
default-consistency-auto-derive
branch
from
2621ce3 to
942d8a5
Compare
piodul
reviewed
Jun 13, 2023
|
@piodul as we are already heading towards 0.9, can we merge this? |
What issue? The description should be more specific. |
piodul
reviewed
Jul 26, 2023
As the awaited issue in `num_enum` crate (illicitonion/num_enum#75) has been resolved in its 0.6 release, it is now possible to derive Default for Consistency automatically.
wprzytula
force-pushed
the
default-consistency-auto-derive
branch
from
942d8a5 to
61c21d9
Compare
done. |
piodul
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the awaited issue in
num_enumcrate has been resolved in its 0.6 release, it is now possible to derive Default for Consistency automatically.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.