Migrate tablets to new deserialization framework #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, Vec<u8> was used as the type for custom payload's values. Bytes are better because: - they allow shared ownership owned those values, - they fit the new deserialization framework (they are required to create a `FrameSlice`), which will allow migrating raw tablets parsing to the new deserialization framework.
The new deserialization framework lets us elide a number of allocations there.
Lorak-mmk
approved these changes
Nov 12, 2024
|
|
muzarski
approved these changes
Nov 12, 2024
Merged
wprzytula
deleted the
migrate-tablets-to-new-deserialization-framework
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tablets were omitted during migration in #1057.
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.