scripts: exit with 1 when Exception catched

On #498, status of scylla-image-post-start.service is NOT "failed" even
the script causing error, because scylla_post_start.py catches all
exceptions and just logging it, so the script finishes without error.

To getting notify users the script failed operation during running, we
should sys.exit(1) when the exception catched.

fixes #505

common/scylla_configure.py

@@ -124,6 +124,7 @@ def run_post_configuration_script(self):
             except Exception as e:
                 scylla_excepthook(*sys.exc_info())
                 LOGGER.error("Post configuration script failed: %s", e)
+                sys.exit(1)
 
     def start_scylla_on_first_boot(self):
         default_start_scylla_on_first_boot = self.CONF_DEFAULTS["start_scylla_on_first_boot"]
@@ -141,6 +142,7 @@ def create_devices(self):
         except Exception as e:
             scylla_excepthook(*sys.exc_info())
             LOGGER.error("Failed to create devices: %s", e)
+            sys.exit(1)
 
     def configure(self):
         self.configure_scylla_yaml()

common/scylla_create_devices

@@ -93,3 +93,4 @@ if __name__ == "__main__":
         create_raid(disk_devices, args.raid_level)
     except (DiskIsNotEmptyError, NoDiskFoundError) as e:
         print(e)
+        sys.exit(1)

common/scylla_post_start.py

@@ -30,6 +30,7 @@ def run_post_start_script(self):
             except Exception as e:
                 scylla_excepthook(*sys.exc_info())
                 LOGGER.error(f"Post start script failed: {e}")
+                sys.exit(1)
 
 
 if __name__ == "__main__":