gemini: pretty print CQL queries #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
reviewed
Apr 29, 2019
cmd/gemini/root.go
Outdated
| @@ -262,11 +263,15 @@ func mutationJob(schema *gemini.Schema, table gemini.Table, s *gemini.Session, p | |||
| mutateQuery := mutateStmt.Query | |||
| mutateValues := mutateStmt.Values() | |||
| if verbose { | |||
| fmt.Printf("%s (values=%v)\n", mutateQuery, mutateValues) | |||
| fmt.Printf("mutationJob: %s\n", mutateStmt.PrettyCQL()) | |||
There was a problem hiding this comment.
How about we print only the CQL statement without that mutationJob prefix? It's easier to copy-paste a full line to a bug report or cqlsh.
dahankzter
force-pushed
the
executable_printed_statements
branch
from
fb05962
to
ab23aa8
Compare
|
Is the Go version I have too old for this? [penberg@nero gemini]$ ./scripts/gemini-launcher --drop-schema --duration=10s
# github.com/scylladb/gemini
./types.go:473:33: reflect.ValueOf(value[0]).MapRange undefined (type reflect.Value has no field or method MapRange)
Compilation failed
[penberg@nero gemini]$ go version
go version go1.11.5 linux/amd64 |
|
Jupp it's since 1.12 https://go-review.googlesource.com/c/go/+/33572/ too bad the Go docs don't include a |
The type information of a particular statement is recorded when the statement is generated to allow for type specific rendering of the different parts of the queries.
dahankzter
force-pushed
the
executable_printed_statements
branch
from
ab23aa8
to
dde7562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type information of a particular statement is recorded when
the statement is generated to allow for type specific rendering
of the different parts of the queries.
Fixes: #38