schema: Restrict partition key type to int #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We partition keyspace between different concurrent goroutines to ensure there are no concurrent writes when we read. However, as pointed out by Henrik, the partition keys are mapped to tokens and there are no guarantees that the mapping respects the partitioning for arbitrary types, which can lead to a concurrent write on the partition we are reading from. Threfore, restrict partition key type to int, which fixes the Gemini complaint that oracle and test cluster results sets have different sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We partition keyspace between different concurrent goroutines to ensure
there are no concurrent writes when we read. However, as pointed out by
Henrik, the partition keys are mapped to tokens and there are no
guarantees that the mapping respects the partitioning for arbitrary
types, which can lead to a concurrent write on the partition we are
reading from.
Threfore, restrict partition key type to int, which fixes
the Gemini complaint that oracle and test cluster results sets have
different sizes.