New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stmtlogger): lets gemini work with empty 'test-statement-log-file' option #416

Merged

dkropachev merged 1 commit into scylladb:master from illia-li:il/fix-stmtlogger-add-nop-filelogger

Dec 27, 2023

Contributor

illia-li commented Dec 27, 2023

Empty 'test-statement-log-file' option brings to panic.
Reason:

func NewFileLogger(filename string) (StmtToFile, error) {
	if filename == "" {
		return nil, nil
...

func (fl *fileLogger) LogStmt(stmt *typedef.Stmt) {
	ch := fl.activeChannel.Load()
...


          fix(stmtlogger): lets gemini work without 'test-statement-log-file' o…

db2aa96

…ption

dkropachev merged commit 916bff7 into scylladb:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet