Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(store): queries syncer #375

Merged
merged 2 commits into from
Jul 10, 2023
Merged

add(store): queries syncer #375

merged 2 commits into from
Jul 10, 2023

Conversation

illia-li
Copy link
Contributor

As solution issue #365.
Added simple logic to synchronize identical queries on "testStore" and oracalStore'.
As results:

  1. Time difference between Stmt start on 'testStore' and 'oracalStore' is 10-300μs, before was from 350-20000μs
  2. Productivity has increased by about 30%
  3. Repeats on queries with big responses gone away.

@illia-li illia-li force-pushed the il/add-store-queries_syncer branch 2 times, most recently from 9cfe361 to 42f39e2 Compare June 26, 2023 01:45
@illia-li illia-li changed the title add(store) queries syncer add(store): queries syncer Jul 1, 2023
@illia-li illia-li force-pushed the il/add-store-queries_syncer branch 2 times, most recently from ff28d19 to 5321d9f Compare July 7, 2023 15:11
@illia-li illia-li marked this pull request as ready for review July 7, 2023 15:14
@illia-li illia-li force-pushed the il/add-store-queries_syncer branch from 5321d9f to 43e84e4 Compare July 7, 2023 15:58
dkropachev
dkropachev reviewed Jul 10, 2023
View reviewed changes
pkg/store/store.go Outdated Show resolved Hide resolved
pkg/store/store.go Outdated Show resolved Hide resolved
@illia-li illia-li requested a review from dkropachev July 10, 2023 01:34
dkropachev
dkropachev requested changes Jul 10, 2023
View reviewed changes
pkg/store/store.go Outdated Show resolved Hide resolved
@illia-li illia-li force-pushed the il/add-store-queries_syncer branch from 43e84e4 to 94f8ad5 Compare July 10, 2023 17:16
@illia-li illia-li requested a review from dkropachev July 10, 2023 17:19
dkropachev
dkropachev requested changes Jul 10, 2023
View reviewed changes
pkg/store/store.go Show resolved Hide resolved
@illia-li illia-li requested a review from dkropachev July 10, 2023 17:54
dkropachev
dkropachev requested changes Jul 10, 2023
View reviewed changes
pkg/store/store.go Outdated Show resolved Hide resolved
@illia-li illia-li force-pushed the il/add-store-queries_syncer branch from 3ea7750 to 7c33379 Compare July 10, 2023 17:59
@illia-li illia-li requested a review from dkropachev July 10, 2023 18:00
@dkropachev dkropachev merged commit c4a4a8f into scylladb:master Jul 10, 2023
@illia-li illia-li deleted the il/add-store-queries_syncer branch July 11, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illia-li @dkropachev