Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SchemaConfig) Valid() - fix errors #366

Conversation

illia-li
Copy link
Contributor

fixed error:

if sc.MaxColumns <= sc.MinClusteringKeys {
		return ErrSchemaConfigInvalidCols
	}

renamed errors. Sample:
ErrSchemaConfigInvalidCols >>>ErrSchemaConfigInvalidRangeCols

@illia-li illia-li force-pushed the il/fix-schema_config_validation-fix_errors branch 4 times, most recently from d796e1a to bc6577a Compare June 21, 2023 14:30
*fix wrong error condition
*rename validation schema errors
@illia-li illia-li force-pushed the il/fix-schema_config_validation-fix_errors branch from bc6577a to 4a7f50b Compare June 21, 2023 14:39
@illia-li illia-li marked this pull request as ready for review June 21, 2023 17:40
@dkropachev dkropachev merged commit bf8224e into scylladb:master Jun 22, 2023
@illia-li illia-li deleted the il/fix-schema_config_validation-fix_errors branch June 22, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants