Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): speedup random string generation #325

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(utils): speedup random string generation #325

merged 1 commit into from
May 30, 2023

Conversation

dkropachev
Copy link
Collaborator

Results:

pkg: github.com/scylladb/gemini/pkg/utils
cpu: 12th Gen Intel(R) Core(TM) i9-12900HK
BenchmarkUtilsRandStringNew100
BenchmarkUtilsRandStringNew100-20     	 9158696	       157.4 ns/op
BenchmarkUtilsRandStringNew1000
BenchmarkUtilsRandStringNew1000-20    	 2407350	       592.3 ns/op
BenchmarkUtilsRandStringOld100
BenchmarkUtilsRandStringOld100-20      	 1878685	       666.5 ns/op
BenchmarkUtilsRandStringOld1000
BenchmarkUtilsRandStringOld1000-20     	  174566	      6064 ns/op
PASS

@dkropachev dkropachev merged commit ac72aef into master May 30, 2023
@dkropachev dkropachev deleted the dk/speedup_rand_string branch May 30, 2023 00:18
@dorlaor
Copy link
Contributor

dorlaor commented May 30, 2023

Cheers Dmitry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkropachev @dorlaor