fix(root.createClusters): Use request-timeout parameter for Oracle #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vponomaryov
reviewed
May 29, 2023
cmd/gemini/root.go
Outdated
| @@ -371,7 +371,7 @@ func createClusters( | |||
| return testCluster, nil | |||
| } | |||
| oracleCluster := gocql.NewCluster(oracleClusterHost...) | |||
| oracleCluster.Timeout = 120 * time.Second | |||
| oracleCluster.Timeout = requestTimeout | |||
There was a problem hiding this comment.
What about the connectTimeout? It is also not set here.
Oracle cluster use fixed request timeout 120s, while test cluster user configurable request timeout provided by --request-timeout parameter. This cause request time for queries to oracle cluster for MV, SI. Set same parameter for Oracle cluster
dkropachev
force-pushed
the
fix-oracle-requst-timeout
branch
from
da119c2
to
867c7f0
Compare
dkropachev
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle cluster use fixed request timeout 120s, while test cluster user configurable request timeout provided by --request-timeout parameter. This cause request time for queries to oracle cluster for MV, SI.
Set same parameter for Oracle cluster