gemini: warmup time configurable using cli argument #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not make total runtime always "warmup + duration"? To me, that seems easier to reason about. |
penberg
reviewed
Jun 5, 2019
| @@ -398,6 +415,7 @@ func init() { | |||
| rootCmd.Flags().BoolVarP(&nonInteractive, "non-interactive", "", false, "Run in non-interactive mode (disable progress indicator)") | |||
| rootCmd.Flags().DurationVarP(&duration, "duration", "", 30*time.Second, "") | |||
| rootCmd.Flags().StringVarP(&outFileArg, "outfile", "", "", "Specify the name of the file where the results should go") | |||
| rootCmd.Flags().DurationVarP(&warmup, "warmup", "", 30*time.Second, "Specify the warmup perid as a duration for example 30s or 10h") | |||
There was a problem hiding this comment.
If warmup is included in duration, this default means we do no testing, right?
|
You are right the default is not very good.
I didn't notice it because the script sets a 10 minutes duration.
As for which total running time we use it doesn't matter much. You either
have to subtract or add the times to know what's what.
It was very simple in the current implementation since there was no need to
change the existing duration code.
…On Wed, Jun 5, 2019, 11:06 Pekka Enberg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/gemini/root.go
<#131 (comment)>:
> @@ -398,6 +415,7 @@ func init() {
rootCmd.Flags().BoolVarP(&nonInteractive, "non-interactive", "", false, "Run in non-interactive mode (disable progress indicator)")
rootCmd.Flags().DurationVarP(&duration, "duration", "", 30*time.Second, "")
rootCmd.Flags().StringVarP(&outFileArg, "outfile", "", "", "Specify the name of the file where the results should go")
+ rootCmd.Flags().DurationVarP(&warmup, "warmup", "", 30*time.Second, "Specify the warmup perid as a duration for example 30s or 10h")
If warmup is *included* in duration, this default means we do no testing,
right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#131?email_source=notifications&email_token=AABJYU26VMBGHH34WVCWV4DPY56ZPA5CNFSM4HTTB47KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2T7BJQ#pullrequestreview-245887142>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJYU5P7OWZI5GNOY7PRNDPY56ZPANCNFSM4HTTB47A>
.
|
dahankzter
force-pushed
the
warmup
branch
2 times, most recently
from
8b32585
to
2ea6729
Compare
|
I have changed the total run time to be the sum of the warmup and duration arguments. |
Gemini now has a cli argument 'warmup' which is a duration given in a format such as '30s', '15m' or '10h'. This time is added to the duration time so as to make total run time easy to calculate. For example: Given a duration of 10h and a warmup of 2h the total runtime will be an 12 hours and validations will start to happen after a 2 hours warmup run with only inserts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemini now has a cli argument 'warmup' which is a duration given
in a format such as '30s', '15m' or '10h'.
This time is taken from the duration time so as to make total run
time easy to set.
For example: Given a duration of 10h and a warmup of 2h there will
be an 8 hours window where validations happen after a 2 hours run
with only inserts.
Fixes: #129