Schema generation support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error condition in generateValue() is ignored because the error object created with fmt.Errorf() is not returned anywhere. As this is an internal error, let's just call panic() to stop execution.
The schema is currently configured via an external file "schema.json". This commit adds support for generating the schema with the tool. Users can still define the schema themselves via a JSON file with the "--schema" command line option. Fixes #9
penberg
force-pushed
the
schema-gen
branch
2 times, most recently
from
1a4e095
to
ee16b56
Compare
dahankzter
reviewed
Mar 6, 2019
| func GenSchema() *Schema { | ||
| builder := NewSchemaBuilder() | ||
| keyspace := Keyspace{ | ||
| Name: "ks1", |
There was a problem hiding this comment.
Is the ks1 a convention? In the old config file it was called gemini or perhaps this is a different keyspace?
dahankzter
reviewed
Mar 6, 2019
| columns = append(columns, ColumnDef{Name: genColumnName("col", i), Type: genColumnType()}) | ||
| } | ||
| table := Table{ | ||
| Name: "table1", |
There was a problem hiding this comment.
Same as the keyspace above. Are they keys into a config?
There was a problem hiding this comment.
The original configuration keyspace and table names were picked at random, like the ones here too. The benefit of this convention is that we can generate multiple keyspaces and tables at a later point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implement schema generation in the Gemini tool. Previously, schema was configured via an external file,
schema.json. This adds a--schemacommand line option, which users can use for the old behavior. If no schema file is configured, the tool generates one.Fixes #9.