-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation failed at map_fast64.go:84 (memory leak related) #267
Comments
It looks like a golang issue, but I can't reproduce it, here is the test I'am using:
|
Reproduced in 5.0.0 similarly with an error in
Installation detailsKernel Version: 5.13.0-1031-aws Scylla Nodes used in this run:
OS / Image: Test: Issue description>>>>>>>
Logs:
|
Issue descriptionThe error was reproduced in this run (this time at
Full error log: Installation detailsKernel Version: 5.15.0-1026-aws Cluster size: 3 nodes (i3.large) Scylla Nodes used in this run:
OS / Image: Test: Logs and commands
Logs:
|
clearly there's a memory leak here: @piodul @avelanarius, is https://github.com/scylladb/go-set is used in any other go projects we have ? |
@roydahan I don't have permissions here, can you edit the title to add the information it's a memory leak |
Happens again Issue description
Installation detailsKernel Version: 5.15.0-1028-aws Cluster size: 3 nodes (i3.4xlarge) Scylla Nodes used in this run:
OS / Image: Test: Logs and commands
Logs:
|
Reason for this leak is the that golang maps are not shrinking when you do delete on them. |
Quite intuitive of golang... I'm not sure why the go-set package was used to begin with, probably for speed... |
Please take a look at #280 |
The reason for this leak is the that golang maps are not shrinking when you do delete on them. Under the hood, for tracking inflight tokens `u64set` is used from `go-set` which is based on map, key for which is token gemini is addressing, no wonder it is leaking memory. Solution is to shrink map ocassionaly.
The reason for this leak is the that golang maps are not shrinking when you do delete on them. Under the hood, for tracking inflight tokens `u64set` is used from `go-set` which is based on map, key for which is token gemini is addressing, no wonder it is leaking memory. Solution is to shrink map ocassionaly.
Closed by c350bbe |
Cmd:
Result:
Full gemini log:
gemini-l0-d901a928-2e03-4de0-bca2-2c170e7bed42.log
The text was updated successfully, but these errors were encountered: