Merge pull request #100 from scylladb/avoid_okbucket_int32_overflow

gemini: ensure max pk per bucket in valid range
scylladb · May 16, 2019 · 7e7847d · 7e7847d
2 parents 76a426c + 7527734
commit 7e7847d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Gemini ensures that primary key buckets do not overflow int32.
 - Gemini now accepts a list of node host names or IPs for the test
   and Oracle clusters.
 - Default maximum primary keys increased to MAX_INT32/concurrency.

diff --git a/cmd/gemini/root.go b/cmd/gemini/root.go
@@ -128,7 +128,7 @@ func readSchema(confFile string) (*gemini.Schema, error) {
 }
 
 func run(cmd *cobra.Command, args []string) {
-	if pkNumberPerThread == 0 {
+	if pkNumberPerThread <= 0 || pkNumberPerThread > (math.MaxInt32/concurrency) {
 		pkNumberPerThread = math.MaxInt32 / concurrency
 	}
 	if err := printSetup(); err != nil {