Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup spatialimage #594

Merged
merged 16 commits into from
Jun 21, 2024
Merged

Conversation

melonora
Copy link
Collaborator

depends on #588

Remaining cleanup of SpatialImage and MultiscaleSpatialImage

@melonora melonora requested review from LucaMarconato and giovp June 19, 2024 17:46
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (eec6ab3) to head (1310b47).

Current head 1310b47 differs from pull request most recent head 7e6f45d

Please upload reports for the commit 7e6f45d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   91.98%   91.96%   -0.03%     
==========================================
  Files          44       44              
  Lines        6615     6605      -10     
==========================================
- Hits         6085     6074      -11     
- Misses        530      531       +1     
Files Coverage Δ
src/spatialdata/_core/centroids.py 100.00% <100.00%> (ø)
src/spatialdata/_core/data_extent.py 97.93% <100.00%> (-0.02%) ⬇️
src/spatialdata/_core/operations/aggregate.py 94.38% <100.00%> (-0.07%) ⬇️
src/spatialdata/_core/operations/map.py 100.00% <100.00%> (+2.17%) ⬆️
src/spatialdata/_core/operations/rasterize.py 90.49% <ø> (-0.07%) ⬇️
src/spatialdata/_core/operations/vectorize.py 94.40% <100.00%> (-0.04%) ⬇️
src/spatialdata/_core/query/spatial_query.py 95.17% <ø> (ø)
src/spatialdata/_core/spatialdata.py 90.57% <ø> (-0.23%) ⬇️
src/spatialdata/_io/io_raster.py 95.65% <100.00%> (ø)
src/spatialdata/_types.py 76.92% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@LucaMarconato
Copy link
Member

Thanks! I will review it after #588 is merged.

@LucaMarconato LucaMarconato mentioned this pull request Jun 21, 2024
@LucaMarconato
Copy link
Member

LGTM thanks! Also nice the fix around the table accessor, well spotted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants